Initial implementation of brain-atlas endpoints
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #168 for the specification. Briefly; a `BrainAtlas` is an named entity that has an asset `annotation.nrrd` attached to it. It is associated with a particular `BrainRegionHierarchy` In addition, `BrainAtlasRegion` gives metadata for all the regions within a `BrainAtlas`; * their volume in the `annotation.nrrd` if they are a leaf, -1 otherwise. * an attached asset with the .obj mesh
mgeplf
force-pushed
the
brain-atlas
branch
4 times, most recently
from
160bbcf to
4dd7614
Compare
mgeplf
requested review from
GianlucaFicarelli,
bilalesi,
eleftherioszisis and
g-bar
mgeplf
force-pushed
the
brain-atlas
branch
3 times, most recently
from
9a47610 to
ece8bbf
Compare
Comment on lines
41
to
44
| with ensure_result(error_message="Brain Region Hierarchy not found"): | ||
| stmt = sa.select(BrainRegionHierarchy).filter(BrainRegionHierarchy.id == id_) | ||
| row = db.execute(stmt).scalar_one() | ||
| return BrainRegionHierarchyRead.model_validate(row) |
There was a problem hiding this comment.
Minor: You could use the app.queries.common.router_read_one here too, right?
There was a problem hiding this comment.
ah, I was just fixing a typo, and wasn't really looking at this file.
| db_model_class=BrainAtlasRegion, | ||
| authorized_project_id=user_context.project_id, | ||
| response_schema_class=BrainAtlasRegionRead, | ||
| apply_operations=lambda q: q.filter(BrainAtlasRegion.brain_atlas_id == atlas_id), |
There was a problem hiding this comment.
Minor, can we use q.where instead of q.filter in new code here and at line 62?
They are aliases, but where is more similar to how the conditions is represented in the final query.
There was a problem hiding this comment.
let me try again, I think I did that the first time, but I'm not sure.
eleftherioszisis
approved these changes
May 26, 2025
jdcourcol
pushed a commit
that referenced
this pull request
May 26, 2025
See #168 for the specification. Briefly; a `BrainAtlas` is an named entity that has an asset `annotation.nrrd` attached to it. It is associated with a particular `BrainRegionHierarchy` In addition, `BrainAtlasRegion` gives metadata for all the regions within a `BrainAtlas`; * their volume in the `annotation.nrrd` if they are a leaf, None otherwise. * an attached asset with the .obj mesh
jdcourcol
pushed a commit
that referenced
this pull request
May 26, 2025
See #168 for the specification. Briefly; a `BrainAtlas` is an named entity that has an asset `annotation.nrrd` attached to it. It is associated with a particular `BrainRegionHierarchy` In addition, `BrainAtlasRegion` gives metadata for all the regions within a `BrainAtlas`; * their volume in the `annotation.nrrd` if they are a leaf, None otherwise. * an attached asset with the .obj mesh
mgeplf
added a commit
that referenced
this pull request
May 27, 2025
See #168 for the specification. Briefly; a `BrainAtlas` is an named entity that has an asset `annotation.nrrd` attached to it. It is associated with a particular `BrainRegionHierarchy` In addition, `BrainAtlasRegion` gives metadata for all the regions within a `BrainAtlas`; * their volume in the `annotation.nrrd` if they are a leaf, None otherwise. * an attached asset with the .obj mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #168 for the specification.
Briefly; a
BrainAtlasis an named entity that has an assetannotation.nrrdattached to it. It is associated with a particularBrainRegionHierarchyIn addition,
BrainAtlasRegiongives metadata for all the regions within aBrainAtlas;annotation.nrrdif they are a leaf, -1 otherwise.