Skip to content

Conversation

@eleftherioszisis
Copy link
Contributor

Allow querying brain region meshes using brain region ids.

@eleftherioszisis eleftherioszisis changed the title Add brain region mesh routers/schemas/service Add brain region mesh router/schemas/service May 11, 2025
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was going to be part of the BrainAtlas work, so I've been putting somewhat equivalent functionality (along w/ the volumes) into the implementation for the spec: #168

@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented May 19, 2025

If this is going to be replaced by the BrainAtlas PR, I should close it. It was submitted before discussing of the new functionality.

@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented May 19, 2025

However, is it really equivalent functionality? Not sure how the sdks will be able to fetch BrainMesh as normal entities independently of a BrainAtlas. BrainAtlas provides a context for a subset of meshes per atlas, but why should it be disallowed to fetch meshes as regular entities?

@mgeplf
Copy link
Collaborator

mgeplf commented May 19, 2025

IMO, a mesh is only useful within the context of a BrainAtlas (ie: you don't need to get all the meshes); as such, I think it should be modeled as an asset "attached" to a BrainAtlasRegion (ie: a region within the BrainAtlas)

@eleftherioszisis
Copy link
Contributor Author

Having a BrainAtlasRegion with a mesh asset and other information created due to the atlas context makes perfect sense. I still think though we need to be able to also query them independently, but that can come later if needed.

I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants