Skip to content

initial version of within_brain_region #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 9, 2025
Merged

initial version of within_brain_region #148

merged 14 commits into from
May 9, 2025

Conversation

@mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented May 2, 2025

No description provided.

@mgeplf mgeplf force-pushed the simplified-brain-regions branch from 96ff40c to 1cd2367 Compare May 6, 2025 06:45
@mgeplf mgeplf force-pushed the simplified-brain-regions branch from 8906b57 to 676fa04 Compare May 6, 2025 07:24
@mgeplf mgeplf marked this pull request as ready for review May 6, 2025 07:45
mgeplf
mgeplf commented May 6, 2025
View reviewed changes
mgeplf
mgeplf commented May 6, 2025
View reviewed changes
mgeplf
mgeplf commented May 6, 2025
View reviewed changes
mgeplf
mgeplf commented May 6, 2025
View reviewed changes
jdcourcol
jdcourcol reviewed May 6, 2025
View reviewed changes
eleftherioszisis
eleftherioszisis reviewed May 6, 2025
View reviewed changes
mgeplf added 2 commits May 6, 2025 14:07
@mgeplf
clamp mesh imports to ones tagged at v1.1.0
3826e0e
@mgeplf
review comments
885e47b 
* add brain-region-hierarchy-name endpoint
* move hierarchy to  "/brain-region-hierarchy-name/{id_}/hierarchy",
@mgeplf mgeplf mentioned this pull request May 7, 2025
Closed
GianlucaFicarelli
GianlucaFicarelli reviewed May 7, 2025
View reviewed changes
@eleftherioszisis
Copy link
Contributor

eleftherioszisis commented May 8, 2025

Would it be possible to rename brain-region-hierarchy-name into brain-region-hierarchy? Not sure why we need the name postfix, given that we fetch it by uuid.

@mgeplf mgeplf force-pushed the simplified-brain-regions branch from 831522c to 02b28ba Compare May 9, 2025 09:48
@mgeplf
comments
3b7b5f9 
* Rename BrainRegionHierarchyName to just BrainRegionHierarchy
* for a brain region, its `id` in the original hierarchy.json is now
  called `annotation_value`: anything w/ `_id` in the name suggests
  it refers to a table in the DB
@mgeplf mgeplf force-pushed the simplified-brain-regions branch from 02b28ba to 3b7b5f9 Compare May 9, 2025 10:19
@mgeplf mgeplf force-pushed the simplified-brain-regions branch from 8aff6a2 to bf61a7f Compare May 9, 2025 12:16
eleftherioszisis
eleftherioszisis approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mgeplf mgeplf merged commit 56fb881 into main May 9, 2025
1 check passed
@mgeplf mgeplf deleted the simplified-brain-regions branch May 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdcourcol jdcourcol jdcourcol left review comments

@GianlucaFicarelli GianlucaFicarelli GianlucaFicarelli left review comments

@eleftherioszisis eleftherioszisis eleftherioszisis approved these changes

@bilalesi bilalesi Awaiting requested review from bilalesi

@g-bar g-bar Awaiting requested review from g-bar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mgeplf @eleftherioszisis @jdcourcol @g-bar @GianlucaFicarelli