Skip to content

Conversation

@pgetta
Copy link
Collaborator

@pgetta pgetta commented Nov 3, 2025

This PR makes it possible to create and launch a simulation campaign using obi-one with a similar UI used in circuit simulations. For the moment this is going to be available only in dev.

Related to https://github.com/openbraininstitute/prod-singlecell-simulation/issues/200.

@pgetta pgetta self-assigned this Nov 3, 2025
@pgetta pgetta force-pushed the feat/me-model-circuit-simulation branch from b0bbfc9 to 63b7caf Compare November 3, 2025 13:10
@pgetta pgetta requested a review from bilalesi November 4, 2025 07:07
@pgetta pgetta force-pushed the feat/me-model-circuit-simulation branch from 3767316 to 51623bc Compare November 4, 2025 09:12
@pgetta
Copy link
Collaborator Author

pgetta commented Nov 4, 2025

Sorry @bilalesi for all the spam, this should be good now.

There are quite a lot of changes, please let me know if you want to go thru them / discuss over a zoom call.

@pgetta pgetta force-pushed the feat/me-model-circuit-simulation branch from 79879e3 to 7488f22 Compare November 4, 2025 10:00
bilalesi
bilalesi previously approved these changes Nov 4, 2025
Copy link
Collaborator

@bilalesi bilalesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice job!, the cookie thing looks solid too, nitpick, probably to have a json file that can have all the flags rather then js object,

@pgetta
Copy link
Collaborator Author

pgetta commented Nov 4, 2025

lgtm, nice job!, the cookie thing looks solid too, nitpick, probably to have a json file that can have all the flags rather then js object,

Do you mean to store a list of feature (keys) which are enabled?

I'll merge the PR and will address the outcome of this conversation in a separate change.

@pgetta pgetta merged commit 316701a into develop Nov 4, 2025
4 checks passed
@pgetta pgetta deleted the feat/me-model-circuit-simulation branch November 4, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants