Skip to content

fix circuit id not found, return null #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix circuit id not found, return null #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...virtual-lab/[virtualLabId]/[projectId]/workflows/simulate/configure/circuit/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export default function Page({

const { data: entity } = useSuspenseQuery({
queryKey: [modelId],
queryFn: () => getCircuit({ id: modelId, context: { virtualLabId, projectId } }),
queryFn: () =>
modelId ? getCircuit({ id: modelId, context: { virtualLabId, projectId } }) : null,
});

const {
Expand All @@ -52,7 +53,7 @@ export default function Page({
},
});

if (error) {
if (error || !entity) {
return notFound();
}

Expand Down
2 changes: 1 addition & 1 deletion src/entity-configuration/definitions/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function RenderCustomField<R extends EntityCoreIdentifiable>({
useEffect(() => {
async function getEntity() {
setPayload({ entity: null, error: null, loading: true });
if (entityConfig && entityConfig.api.query.one) {
if (entityConfig && entityConfig.api.query.one && entityId) {
const { data, error } = await tryCatch<R, any>(
// @ts-ignore
entityConfig.api.query.one({ id: entityId, context: { virtualLabId, projectId } })
Expand Down
5 changes: 3 additions & 2 deletions src/features/small-microcircuit/_components/atoms/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ export const simulationsByCampaignIdAtomFamily = readAtomFamilyWithExpiration(

export const circuitAtomFamily = readAtomFamilyWithExpiration(
({ circuitId, context }: { circuitId: string; context: WorkspaceContext }) =>
atom<Promise<ICircuit>>(async () => {
return getCircuit({ id: circuitId, context });
atom<Promise<ICircuit | null>>(async () => {
if (circuitId) return getCircuit({ id: circuitId, context });
return null;
}),
{
ttl: 120000, // 2 minutes
Expand Down