Avoid requests to entitycore for circuits with the ID 'undefined' #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalesi
reviewed
Oct 30, 2025
Comment on lines
+65
to
+67
| if (id == null) { | ||
| throw new Error(`circuit id is not valid ${id}`); | ||
| } |
There was a problem hiding this comment.
this should not be verified in the query builder level, it should be in the component/caller level
the function should be agnostic from any validation
There was a problem hiding this comment.
I can look around to see where is used and fix it, or if you prefer to do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting a lot of errors in the logs of entitycore for circuits with GUID 'undefined', all coming from core web app. This is a bit a stopgap: avoid such requests and raise an error instead, so hopefully we'll find the root cause.