restrain scipy version to be <1.15 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where do we use median_filter in our code? Could you update the location in the PR description? |
|
@darshanmandge median_filter is used here: https://github.com/openbraininstitute/BluePyEfe/blob/master/bluepyefe/ecode/tools.py#L26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scipy.ndimage.median_filter is bugg since scipy 1.15. We should wait for this error to be solved before allowing latest scipy to be used: scipy/scipy#22250
I have updated PyPi so that it trusts this repo, so we don't need the secrets in the github action anymore