Skip to content

thumbnail plotting in validation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2025
Merged

thumbnail plotting in validation #27

merged 7 commits into from
Jun 24, 2025

Conversation

AurelienJaquier
Copy link
Collaborator

Here is what the thumbnail looks like:

thumbnail.pdf

@AurelienJaquier AurelienJaquier self-assigned this Jun 23, 2025
@darshanmandge darshanmandge mentioned this pull request Jun 23, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
bluecellulab/analysis/analysis.py 98.64% <ø> (-0.01%) ⬇️
bluecellulab/validation/validation.py 100.00% <100.00%> (ø)
tests/test_validation/test_validation.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ilkilic
ilkilic previously approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshanmandge
Copy link
Collaborator

The v_init and celsius parameters affect these thumbnail traces and all the other validations. We should set them before invoking any validation.

jdcourcol
jdcourcol reviewed Jun 23, 2025
View reviewed changes
bluecellulab/validation/validation.py Outdated
)

return {
"name": "Simulatable Neuron Thumbnail Creation",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you name in "Thumbnail" ? otherwise that is different than the legacy ones.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in latest commit

@AurelienJaquier
Copy link
Collaborator Author

The v_init and celsius parameters affect these thumbnail traces and all the other validations. We should set them before invoking any validation.

Done in latest commit. I have set default values of initial voltage at -80 mV, and default value of temperature at 34 C. Those are the values that will be used for all validation, as we currently don't have any additional information about those values in the schema.

jdcourcol
jdcourcol previously approved these changes Jun 24, 2025
View reviewed changes
Copy link

@jdcourcol jdcourcol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@AurelienJaquier AurelienJaquier merged commit bf55dca into main Jun 24, 2025
8 checks passed
@AurelienJaquier AurelienJaquier deleted the thumbnail branch June 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshanmandge darshanmandge darshanmandge approved these changes

@ilkilic ilkilic ilkilic approved these changes

@jdcourcol jdcourcol jdcourcol left review comments

Assignees

@AurelienJaquier AurelienJaquier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AurelienJaquier @darshanmandge @jdcourcol @ilkilic