Skip to content

Memodel validation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 20, 2025
Merged

Memodel validation #14

merged 14 commits into from
May 20, 2025

Conversation

AurelienJaquier
Copy link
Collaborator

partial PR for adding memodel validation. Some validation are missing and should be added later. The return format of the validation might also change in the future.

@AurelienJaquier AurelienJaquier self-assigned this May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bluecellulab/analysis/plotting.py 60.00% 6 Missing ⚠️
bluecellulab/analysis/inject_sequence.py 91.66% 2 Missing ⚠️
Files with missing lines Coverage Δ
bluecellulab/analysis/analysis.py 100.00% <100.00%> (ø)
bluecellulab/stimulus/factory.py 91.19% <100.00%> (+0.52%) ⬆️
bluecellulab/tools.py 97.08% <ø> (ø)
bluecellulab/analysis/inject_sequence.py 97.84% <91.66%> (+0.23%) ⬆️
bluecellulab/analysis/plotting.py 76.47% <60.00%> (-14.84%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AurelienJaquier
Copy link
Collaborator Author

The tests can also be added in a later PR

@AurelienJaquier AurelienJaquier marked this pull request as ready for review May 19, 2025 07:13
@AurelienJaquier AurelienJaquier requested a review from ilkilic May 19, 2025 07:13
ilkilic
ilkilic previously approved these changes May 19, 2025
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks

@AurelienJaquier AurelienJaquier merged commit 5857144 into main May 20, 2025
7 of 8 checks passed
@AurelienJaquier AurelienJaquier deleted the memodel-validation branch May 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants