Skip to content

Commit

Permalink
tools/nolibc: mark start_c as weak
Browse files Browse the repository at this point in the history
Otherwise the different instances of _start_c from each compilation unit
will lead to linker errors:

/usr/bin/ld: /tmp/ccSNvRqs.o: in function `_start_c':
nolibc-test-foo.c:(.text.nolibc_memset+0x9): multiple definition of `_start_c'; /tmp/ccG25101.o:nolibc-test.c:(.text+0x1ea3): first defined here

Fixes: 1733675 ("tools/nolibc: add new crt.h with _start_c")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/lkml/20231012-nolibc-start_c-multiple-v1-1-fbfc73e0283f@weissschuh.net/
Link: https://lore.kernel.org/lkml/20231012-nolibc-linkage-test-v1-1-315e682768b4@weissschuh.net/
Acked-by: Willy Tarreau <w@1wt.eu>
  • Loading branch information
t-8ch committed Oct 12, 2023
1 parent 513bd27 commit 9219922
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/include/nolibc/crt.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const unsigned long *_auxv __attribute__((weak));
static void __stack_chk_init(void);
static void exit(int);

__attribute__((weak))
void _start_c(long *sp)
{
long argc;
Expand Down

0 comments on commit 9219922

Please sign in to comment.