Skip to content

Commit

Permalink
crypto: sm2 - Fix crash caused by uninitialized context
Browse files Browse the repository at this point in the history
In sm2_compute_z_digest() function, the newly allocated structure
mpi_ec_ctx is used, but forget to initialize it, which will cause
a crash when performing subsequent operations.

Fixes: e5221fa ("KEYS: asymmetric: Move sm2 code into x509_public_key")
Cc: stable@vger.kernel.org # v6.5
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
uudiin authored and herbertx committed Sep 20, 2023
1 parent 0bb80ec commit 2115562
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion crypto/sm2.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,14 @@ int sm2_compute_z_digest(struct shash_desc *desc,
if (!ec)
return -ENOMEM;

err = __sm2_set_pub_key(ec, key, keylen);
err = sm2_ec_ctx_init(ec);
if (err)
goto out_free_ec;

err = __sm2_set_pub_key(ec, key, keylen);
if (err)
goto out_deinit_ec;

bits_len = SM2_DEFAULT_USERID_LEN * 8;
entl[0] = bits_len >> 8;
entl[1] = bits_len & 0xff;
Expand Down

0 comments on commit 2115562

Please sign in to comment.