Skip to content

When writing KCS status register the bmc should write Status reg before writing to ODR #1

@crgeddes

Description

@crgeddes

I think we are leaving ourselves open to a race condition if we set the ODR first. Setting the ODR will trigger the OBF bit in the status register which could trigger the host to read right away. If this happened faster than the bmc writes the status then we could miss whatever special status was trying to be written. The function I am referencing is in astlpc.c :

static int mctp_astlpc_kcs_set_status(struct mctp_binding_astlpc *astlpc,
    uint8_t status)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions