plugin_interface

[mesca]

When installing from pip, from openbci import wifi will give an error: ModuleNotFoundError: No module named 'plugin_interface'. It is because plugin_interface.py is outside of the package.

Commenting the line from .plugins import * in openbci/__init__.py fixes the problem. I am not familiar with the plugin system, and maybe this quick fix has side-effects. Is there a better way?

[tushar-c]

I hope somebody responds, I have the same issue.

EDIT: Well, @mesca, I got a temporary solution working, atleast for now. The installer provided in the repo does not seem to install plugin_interfaces. So, here are the steps I did :

1. Install openbci-python with pip

2. Clone this repo onto your machine.

3. Copy the file in the root called 'plugin_interface.py'

4. Then manually paste it into the plugins folder of the directory where openbci-python is installed. So for me the full path looked like:
   "C:\Users\tushar\AppData\Local\Programs\Python\Python35\Lib\site-packages\OpenBCI_Python-1.0.0-py3.5.egg\openbci\plugins"

5. In this directory (the 'plugins' directory), open each file, and see the imports, and replace all imports that say import plugin_interface as plugintypes with from . import plugin_interface as plugintypes. Do this with every file in the plugins directory.

6. Open your terminal (in any directory now), open python, then do from openbci import wifi, it should work. It works for me.

Hope you find this helpful!

[tushar-c]

If this works for you, please close the issue.

[mesca]

Thanks, but your solution and mine are just workarounds, not real fixes. The point is that I don't see the reason for importing ALL the plugins and dependencies in the __init__.py file, when you just need the wifi module.

Anyway, you should probably submit a PR, since at least that makes it useable. Having to manually copying and editing files defeat the purpose of a pip package ;)

[tushar-c]

I agree that having to manually copy and paste and edit files is definitely not something that the user should have to do. However, I wonder what exactly causes this issue. Is the setup.py not able to do a system-wide install of plugin_interfaces ? If so, then how would we fix that?

[mesca]

Well, I think it's because plugin_interface.py is not into the openbci package.

[tushar-c]

By openbci package, you mean the one install through pip, correct?

[mesca]

Yes, but also the normal Python package in the openbci directory (see: https://docs.python.org/3/tutorial/modules.html#packages).

[tushar-c]

Oh, I'm sorry I didn't get you the first time. Anyway, I have submitted a PR. Also, here is a version I made that you can install (still from the .whl file there). So you have to install manually. Here is the link -> https://github.com/tushar-c/openbci-fixed

EDIT: To make sure I'm clear, by manually, I mean you have to download, go to where the .whl file is, then do pip install <package>.

[andrewjaykeller]

Sounds like we need to add the plugin_interface.py into the package that is published with pypi?

[mesca]

Probably :)

[andrewjaykeller]

any ideas how?

[rivasd]

Since this basically breaks the whole package ( I can't even do from openbci import cyton ), I feel like this should be a much higher priority ?

[ChristineZh0u]

Just going to confirm that this issue is still present as of today after installing with pip install openbci-python. Also had to install pyserial "manually" (even though it's in requirements.txt - has the build on PyPi not been updated for a while or something?)