Skip to content

Fix Unit Restart Issue #43#44

Merged
DivineThreepwood merged 3 commits intodevfrom
bugfix/43__unit_restart_deadlock
Jan 11, 2022
Merged

Fix Unit Restart Issue #43#44
DivineThreepwood merged 3 commits intodevfrom
bugfix/43__unit_restart_deadlock

Conversation

@pLeminoq
Copy link
Contributor

@pLeminoq pLeminoq commented Jan 6, 2022

Fix Unit Restart Issue #43

📜 Description

Changes proposed in this pull request:

  • Remove a synchronized statement from a deactivate method which was likely outdated. That this could produce the bug/deadlock has been proven. It remains to be tested that this completely fixed the issue.

@DivineThreepwood
Copy link
Member

This still not solve the issue, right?

@pLeminoq
Copy link
Contributor Author

This still not solve the issue, right?

I'm not sure. At least, it will require extensive testing. In my experiments last week some controllers would still not restart. But that could also have been because I started BCO on the console and did not rebuild.

@DivineThreepwood
Copy link
Member

PR should be fine and will be merged.

@DivineThreepwood DivineThreepwood merged commit 4a6306c into dev Jan 11, 2022
@DivineThreepwood DivineThreepwood deleted the bugfix/43__unit_restart_deadlock branch January 11, 2022 19:17
@DivineThreepwood DivineThreepwood linked an issue Jan 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Units deadlock on configuration change

2 participants