implement caching of unit configs by type#109
Merged
DivineThreepwood merged 1 commit intodevfrom Apr 4, 2023
Merged
Conversation
DivineThreepwood
approved these changes
Apr 4, 2023
DivineThreepwood
added
ready to test
code approved
tested
and removed
ready to review
ready to test
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request:
getUnitConfigsByUnitTypeis called often and before this PR it always iterated over all units. For me, this dropped CPU usage to about 1% when running simulation mode.