Skip to content

Add heroku-24 to the PLATFORM list [replaced] #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianheggie-oaf wants to merge 21 commits into from
Closed

Add heroku-24 to the PLATFORM list [replaced] #1441

ianheggie-oaf wants to merge 21 commits into from

Conversation

@ianheggie-oaf
Copy link
Contributor

@ianheggie-oaf ianheggie-oaf commented Jan 4, 2026

Relevant issue(s)

What does this do?

Adds heroku-18 to the PLATFORM list

Why was this needed?

So we can test heroku-18 scrapers on morph.io

Implementation/Deploy Steps

Standard bundle exec capistrano production deploy

Notes to reviewer (Optional)

Noting else is updated! Another issue and pull request for my branch feature/update-to-heroku-18 will update

  • example scrapers,
  • specs

@ianheggie-oaf ianheggie-oaf self-assigned this Jan 4, 2026
@ianheggie-oaf ianheggie-oaf requested a review from a team as a code owner January 4, 2026 06:15
@ianheggie-oaf ianheggie-oaf mentioned this pull request Jan 4, 2026
Closed
@ianheggie-oaf
Update early_release platform to use heroku-24, test platform file is…
36f6bfd 
… recognised

# Conflicts:
#	spec/models/scraper_spec.rb
@ianheggie-oaf
Update spec description
86d57db
@ianheggie-oaf
Added hello_world_js test for heroku-24 platform
527fd2d
@ianheggie-oaf
Added hello_world_js spec example for cedar-14
f13915f
@ianheggie-oaf
Renamed hello_world_js spec example to clarify its for heroku-18 plat…
17c2720 
…form
@ianheggie-oaf
Remove duplicate Schema Information comment from models and add blank…
8ff737b 
… comment between it and title
@ianheggie-oaf
Moved hello_world_ruby spec example scraper to ..._14
f7f9aaa
@ianheggie-oaf
moved hello_world_subdirectory_js to ..._14
a6f148d
@ianheggie-oaf
Add python3 fallback for limit_output
1f60d88
@ianheggie-oaf
Get docker_runner_spec working for heroku_24 (templates yet to be upd…
477aeab 
…ated)
@ianheggie-oaf
Removed hello_world_js_14 as node.js is no longer supported by cedar-14
30bed40
@ianheggie-oaf
Format using rubocop
f8f22d6
@ianheggie-oaf
Note it is the system ruby that is unavailable not the ruby version r…
a3948bf 
…equested by Gemfile
@ianheggie-oaf
Drop notice that we are falling back to limit_output.py - the user ca…
cf5bc77 
…n't do anything anyway

Update display_env_ruby example to heroku-24 and latest ruby
@ianheggie-oaf
Update display_request_env_ruby to heroku_24 and default ruby
95584c1
@ianheggie-oaf
Update more ruby example scrapers to various ruby version on heroku-24
6e95961
@ianheggie-oaf
Update ruby template scraper to heroku-24
95737a6
@ianheggie-oaf
Updated nodejs example to heroku-24
6b92b29
@ianheggie-oaf
Updated python example to heroku-24 and python3 (replaced scraperwiki…
ff53827 
… as its not python3 ready)
@ianheggie-oaf ianheggie-oaf deleted the feature/enable-heroku-24-platform branch January 5, 2026 12:59
@ianheggie-oaf
Copy link
Contributor Author

ianheggie-oaf commented Jan 5, 2026

Closed as it needed more to have scrapers run - so I updated the examples and other specs to test the different languages
Replaced by

@ianheggie-oaf ianheggie-oaf changed the title Add heroku-24 to the PLATFORM list Add heroku-24 to the PLATFORM list [replaced] Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ianheggie-oaf ianheggie-oaf

Labels

buildpacks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianheggie-oaf