Spring cleanup and restructure - dev to master #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't need to be in the repo.
no longer needed since no more gitbooks
May not be needed (if top level, that's fine). but if a page needed to create this subdir, this content should be updated with links
Includes note about what you won't see in the guide. This could be fleshed out more by others.
Add note about advocacy language; could be fleshed out more with examples, Ben's tool, etc.
Added note about avoiding sharing pump serial; added other gitter channels; added omniaps slack link
general content update. need to add link about first-PR
minor formatting tweaks
need to come back and add link to "your first PR"
adding note about making PRs and linking to list page. need to fix link later.
note about this being google-able
simplify; some stuff will get moved to phase 2
… source/docs/walkthrough/phase-1/visualization.md add why; move to phase 1
add note about setup script; link needs to be fixed though and maybe there's a better source?
…docs/walkthrough/phase-2/using-openaps-tools.md moved to phase 2; tweak title
making note about reviewing data, this could be added to in more detail later though
…e-basal.md to source/docs/walkthrough/phase-3/Understand-determine-basal.md making part of phase 3; notes about using this to decide max basal
renaming and needs to be reordered in the documentation flow
pulling out error checking to be separate
moving error checking here to it's own page
Wip guides included
may need a better way to link to/reference guide, but just linking for now.
removing gitbook reference
formatting tweak
Somehow #111 clobbered clean mergability. Conflicts: docs/docs/walkthrough/phase-0/index.rst docs/index.rst
Spring cleanup and restructure - dana-dev to dev
Changing "Logs files" to "Log files"
Separate two commands into two lines rendered
Contributor
|
👍 on this being better than what's in master and worth merging |
Member
|
Fantastic. This has become the "new default" for the time being, so I'd love to see it merged to master ASAP. If there's anything about dev we're unhappy with as the new defaults, let's figure it out and fix it; since it's been available and we seem to be increasingly depending on it, I think you can feel free to merge/release to master anytime. Big 👍 . |
Contributor
Author
|
Merging spring cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of what's included is referenced in #114 - please see there for notes if you're unfamiliar with the bulk dev changes.
Creating this PR to trigger discussion around anything major that needs to be done before this overtakes master. IMO, dev is good enough as-is, although we know it needs some work on the flow especially as it relates to NS setup; it'd be better to get this to master to get more eyes on what needs improved.
cc @bewest @jasoncalabrese @scottleibrand for comments, fixes in addition to feedback from everyone else. If no major objections (including lack of thumbs up), I'll merge this on Tuesday April 19 (after 4 days).