Skip to content

Fix hyphens in path parameters #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Fix hyphens in path parameters #986

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
381f178
fix: allow hyphens as delimiter in PATH_PARAM_REGEX
Mar 3, 2024
bd28cf7
fix: add path with python names variable to template
Mar 3, 2024
77168cd
Merge branch 'main' into endpoint_path_python_names
dbanty Mar 6, 2024
724f533
chore: reformat
dbanty Mar 6, 2024
a8b3e90
test: Add e2e test
dbanty Mar 6, 2024
544f289
chore: Reorganize path templating
dbanty Mar 6, 2024
ca202a7
chore: document with changeset
dbanty Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: reformat
  • Loading branch information
@dbanty
dbanty committed Mar 6, 2024
commit 724f533125cb5771895176e48e1793dc373192ff
3 changes: 1 addition & 2 deletions openapi_python_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,7 @@ def _build_api(self) -> None:
endpoint_path_python_names = endpoint.path
for parameter in endpoint.path_parameters:
endpoint_path_python_names = endpoint_path_python_names.replace(
f'{{{parameter.name}}}',
f'{{{parameter.python_name}}}'
f"{{{parameter.name}}}", f"{{{parameter.python_name}}}"
)
module_path.write_text(
endpoint_template.render(
Expand Down