fix: run commands in package directory if meta=none #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`project_dir` is set as the working directory if meta generation is turned off. Commands cwd to `project_dir`, so hooks will be run in whatever directory you're running the `generate` command in. The default post-hooks will then run recursively in that directory on any Python files it can find. Set the directory to run commands in to `package_dir` if meta is none, so post-hooks only touch the generated code. fixes openapi-generators#696
Contributor
|
The failed checks seem like they were just a formatting issue. I opened the trivial fix to @brenmous's base branch here: brenmous#1 I can help rebase this off main if this has drifted. |
Contributor
Author
|
Sorry about the formatting, should've followed up on the CI failure. Thanks for fixing it. |
…pi-generators#703) Co-authored-by: Dylan Anthony <dbanty@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1969 1970 +1
=========================================
+ Hits 1969 1970 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project_diris set as the working directory if meta generation is turned off. Commands cwd toproject_dir, so hooks will be run in whatever directory you're running thegeneratecommand in. The default post-hooks will then run recursively in that directory on any Python files it can find.Set the directory to run commands in to
package_dirif meta is none, so post-hooks only touch the generated code.fixes #696