feat: Improve library interface #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Awesome, thanks! A bunch of folks will appreciate this I'm sure 🥰. |
dbanty
previously approved these changes
Sep 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1797 1800 +3
=========================================
+ Hits 1797 1800 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
EltonChou
force-pushed
the
improve_library_interface
branch
from
a608854 to
daf507b
Compare
Contributor
Author
|
Sorry for requesting review again. |
dbanty
approved these changes
Sep 26, 2022
This was referenced Sep 26, 2022
Collaborator
|
Thank you @EltonChou! This makes the developer experience when using this library much better when using an IDE + mypy (an IDE like PyCharm will auto-import from the root ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #675
ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface