fix: Parsing requestBody with $ref #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kigawas
changed the title
# Conflicts: # openapi_python_client/parser/openapi.py
dbanty
approved these changes
Jun 15, 2024
dbanty
added a commit
that referenced
this pull request
Jun 15, 2024
This PR was created by Knope. Merging it will create a new release
### Features
#### Support request body refs
You can now define and reuse bodies via refs, with a document like this:
```yaml
paths:
/something:
post:
requestBody:
"$ref": "#/components/requestBodies/SharedBody"
components:
requestBodies:
SharedBody:
content:
application/json:
schema:
type: string
```
Thanks to @kigawas and @supermihi for initial implementations and
@RockyMM for the initial request.
Closes #633, closes #664, resolves #595.
### Fixes
- Indent of generated code for non-required lists. Thanks @sfowl!
(#1050)
- Parsing requestBody with $ref (#633)
Co-authored-by: GitHub <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
Perhaps similar solution can be applied to #605
Description
The requestBody with $ref was not handled.
requestBodiesin components should be injected into_add_bodyfunction.