Skip to content

fix: Non-string header values [#552 & #553]. Thanks @John98Zakaria! #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 18, 2022
Merged

fix: Non-string header values [#552 & #553]. Thanks @John98Zakaria! #566

merged 11 commits into from
Jan 18, 2022

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Jan 17, 2022 •
edited
Loading

This fixes #552 and replaces #553.

BREAKING CHANGE: Header values will be explicitly transformed or omitted instead of blindly passed to httpx as-is.

TODO:

  • Make integration tests for header values
  • Emit warnings when a header property is requested with a type that's not supported

@dbanty dbanty changed the title fix: Header values [#552 & #553]. Thanks @John98Zakaria! fix: Non-string header values [#552 & #553]. Thanks @John98Zakaria! Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #566 (d9db092) into main (23aebd1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d9db092 differs from pull request most recent head 6718ebd. Consider uploading reports for the commit 6718ebd to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #566   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1661      1674   +13     
=========================================
+ Hits          1661      1674   +13
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)
openapi_python_client/parser/openapi.py 100.00% <100.00%> (ø)
...penapi_python_client/parser/properties/__init__.py 100.00% <100.00%> (ø)
...penapi_python_client/parser/properties/property.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23aebd1...6718ebd. Read the comment docs.

@dbanty dbanty merged commit e1a8b24 into main Jan 18, 2022
@dbanty dbanty deleted the fix/boolean_headers branch January 18, 2022 02:56
dbanty added a commit that referenced this pull request Jan 18, 2022
@dbanty @John98Zakaria
fix: Non-string header values [#552, #553, #566]. Thanks @John98Zakaria!
b6ecb19 
Closes #552.

BREAKING CHANGE: Header values will be explicitly transformed or omitted instead of blindly passed to httpx as-is.

Co-authored-by: John Sorial <johnzakaria98@gmail.com>
Co-authored-by: dbanty <dbanty@users.noreply.github.com>
dbanty added a commit that referenced this pull request Jan 18, 2022
@dbanty @John98Zakaria
fix: Non-string header values [#552, #553, #566]. Thanks @John98Zakaria!
5de5920 
Closes #552.

BREAKING CHANGE: Header values will be explicitly transformed or omitted instead of blindly passed to httpx as-is.

Co-authored-by: John Sorial <johnzakaria98@gmail.com>
Co-authored-by: dbanty <dbanty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean headers improperly handeled by _get_kwargs
2 participants
@dbanty @John98Zakaria