-
-
Notifications
You must be signed in to change notification settings - Fork 228
Fix nullable model properties in from_dict
and to_dict
#315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullable model properties in from_dict
and to_dict
#315
Conversation
cc @dbanty. Sorry, I know you're busy :) We're planning to release our SDK's first version this Friday, so we'll just merge this into our fork if you don't have time to get to it by then. |
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1385 1385
=========================================
Hits 1385 1385 Continue to review full report at Codecov.
|
(cc @bowenwr) |
You've been busy! 😅 This looks good to me, thanks! But I've reviewed several things in a row so I'm not completely trusting my brain 🥱. Gonna request that @emann gives this a second look since it's already past Friday and therefore probably not a rush. Thanks again, hopefully I'll get around to all your other PRs soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well - thanks for all of your contributions @forest-benchling!
Currently, the code only accounts for the
not required
case, not thenullable
case.This PR also adds E2E test coverage.