Fix nullable date/datetime properties

[fyhertz]

No description provided.

[codecov]

Codecov Report

Merging #267 (48a2ac6) into main (3ca219c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1314      1314           
=========================================
  Hits          1314      1314           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca219c...48a2ac6. Read the comment docs.

[dbanty]

Awesome, thanks! Probably another bug from 0.7.1 (FYI @packyg). I think we can simplify the template a bit, take a look at my suggestion.

[dbanty]

Instead, couldn't we do this:

Suggested change

	{% if property.required %}
	{% if property.required and not property.nullable %}

and let the below else handle None?

[dbanty]

Same thing here I think

[packyg]

The changes as they are here would cause type issues, I think, because the type of {{property.python_name}} changes from that of {{source}} (Optional[str]) to Optional[date]

You would need to put the {{source}} in a temp variable for this implementation:

Suggested change

	{{ property.python_name }} = {{ source }}
	{{ property.python_name }} = isoparse({{ property.python_name }}).date() if {{ property.python_name }} else None
	_{{ property.python_name }} = {{ source }}
	{{ property.python_name }} = isoparse(_{{ property.python_name }}).date() if {{ property.python_name }} else None

But I think @dbanty's suggestion would work and would be a bit simpler.

[fyhertz]

Alright, I will try to fix that today!

[dbanty]

I pulled this code into #277 and made the suggested change. Thanks again!