Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade commitlint modules #179

Merged
merged 1 commit into from
Mar 17, 2021
Merged

chore: upgrade commitlint modules #179

merged 1 commit into from
Mar 17, 2021

Conversation

sasaplus1
Copy link
Member

@sasaplus1 sasaplus1 commented Mar 17, 2021

lerna v4と@commitlint/config-lerna-scopes v12.1.0未満を使用するとエラーが発生し、コミットができなくなっていたので@commitlint系モジュールをアップグレードしました。

ref: conventional-changelog/commitlint#2452

close #171

@sasaplus1 sasaplus1 requested review from hiloki and herablog March 17, 2021 07:18
@sasaplus1 sasaplus1 self-assigned this Mar 17, 2021
@reg-suit
Copy link

reg-suit bot commented Mar 17, 2021

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

Copy link
Member

@herablog herablog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正常/異常ローカルで確認できました!

spindle % git commit -am "chore: test"
husky > commit-msg (node v14.15.4)
[fix/commitlint-error 6a98a5c] chore: test
 1 file changed, 1 insertion(+), 1 deletion(-)

spindle % git commit -am "a"
husky > commit-msg (node v14.15.4)
⧗   input: a
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

husky > commit-msg hook failed (add --no-verify to bypass)

@sasaplus1 sasaplus1 merged commit 9ec7403 into main Mar 17, 2021
@sasaplus1 sasaplus1 deleted the fix/commitlint-error branch March 17, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants