Skip to content

Conversation

@pradal
Copy link
Contributor

@pradal pradal commented Sep 15, 2025

No description provided.

@pradal
Copy link
Contributor Author

pradal commented Oct 3, 2025

Please, name your modules (python.py files) with only lower cases.
And also functions.

Use ratp2vtk rather than RATP2VTK
And do not use pyratp into module names.
Because the modules are part of the openalea.ratp package

@pradal
Copy link
Contributor Author

pradal commented Oct 3, 2025

@cyrilbz : Do you need to rename the package openalea.ratp into openalea.pyratp?

@cyrilbz
Copy link
Collaborator

cyrilbz commented Oct 3, 2025

@pradal No, no need to rename the package I think!
I updated my branch with the new 3D voxel viewer (based on PyVista library), see attached screenshot.
Screenshot From 2025-10-03 11-31-08

I will start now satisfying your request about upper/lower cases, and will let you know when I am done.

@cyrilbz
Copy link
Collaborator

cyrilbz commented Oct 3, 2025

@pradal I resolved the upper case issue for module names. Changing the file name RATP2VTK.py into lower case requires changing meson.build in src/openalea/ratp, and it's not the only file name that contains upper cases... let me know if you want me to update all of them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants