Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.8 #201

Merged
merged 21 commits into from
Apr 26, 2020
Merged

python 3.8 #201

merged 21 commits into from
Apr 26, 2020

Conversation

christopherhesse
Copy link
Collaborator

fixes #197

@christopherhesse
Copy link
Collaborator Author

@endrift seems like python's dev.msi for python 3.8 does not include libpython.a only python.lib, any ideas on how to workaround that?

@christopherhesse
Copy link
Collaborator Author

It seems like there might be different rules for linking against libpython for 3.8: https://docs.python.org/3/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

@endrift
Copy link
Contributor

endrift commented Apr 25, 2020

@christopherhesse not sure if it'll still link properly, but you might be able to just rename it to libpython.a. They're in the same format, it's just the lib file is targeted for MSVC.

@christopher-hesse
Copy link

here's a converted one from https://code.google.com/archive/p/lib2a/ in case that does not work convert.zip

@christopher-hesse
Copy link

another option:

from https://stackoverflow.com/questions/11793370/how-can-i-convert-a-vsts-lib-to-a-mingw-a

curl -O https://www.python.org/ftp/python/3.8.2/amd64/core.msi
7z x core.msi
apt-get install --yes apt-get install mingw-w64-tools
gendef python.dll
/usr/bin/x86_64-w64-mingw32-dlltool --as-flags=--64 -m i386:x86-64 -k --output-lib libpython.a --input-def python.def

@christopherhesse
Copy link
Collaborator Author

Thanks for the suggestion @endrift! I couldn't get that to work but the dlltool thing at least finished compiling.

@christopherhesse christopherhesse marked this pull request as ready for review April 26, 2020 04:10
@christopherhesse christopherhesse merged commit bf21ddb into master Apr 26, 2020
squishyhuman pushed a commit to RetroAI/retro3 that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add python 3.8 wheels
3 participants