Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wandb): no results if not succeeded #74

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix(wandb): no results if not succeeded #74

merged 1 commit into from
Mar 1, 2022

Conversation

borisdayma
Copy link
Contributor

Fixes issue where we tried to access a results file even when finetune status was not "succeeded"

@borisdayma borisdayma marked this pull request as ready for review February 28, 2022 15:11
@borisdayma
Copy link
Contributor Author

borisdayma commented Feb 28, 2022 •
edited
Loading

Fix confirmed to be working here

@christinakim christinakim merged commit 101b444 into openai:main Mar 1, 2022
@stainless-bot stainless-bot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinakim christinakim christinakim approved these changes

@BorisPower BorisPower Awaiting requested review from BorisPower

@rachellim rachellim Awaiting requested review from rachellim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borisdayma @christinakim