Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry_points #52

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Add entry_points #52

merged 1 commit into from
Jan 25, 2022

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Dec 8, 2021

This PR updates the repo to use the more modern entry_points.

Ref: https://packaging.python.org/guides/distributing-packages-using-setuptools/#scripts

Closes #48

@BastianZim BastianZim marked this pull request as ready for review December 8, 2021 16:49
@BastianZim
Copy link
Contributor Author

@hallacy Would it be possible to get a quick review here? Thanks! :)

@hallacy
Copy link
Collaborator

hallacy commented Jan 24, 2022

This looks right. Out of curiosity, was the file rename due to needing a reference-able path for entry_points?

@BastianZim
Copy link
Contributor Author

Yes. There's probably a workaround but I find this is neater. :)

Copy link
Collaborator

@hallacy hallacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We'll roll it out in the next release

@hallacy hallacy merged commit 3dc4b91 into openai:main Jan 25, 2022
@BastianZim BastianZim deleted the entry_points branch January 26, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use entry_points console_scripts
2 participants