fix: create upload example fixtures in private directories - #3686
Merged
Conversation
apcha-oai
marked this pull request as ready for review
August 19, 2026 21:02
apcha-oai
enabled auto-merge
August 19, 2026 21:03
Contributor
apcha-oai
disabled auto-merge
August 19, 2026 21:04
jbeckwith-oai
approved these changes
Aug 19, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Independent two-pass security review of the complete true-merge-base diff found no actionable issues. Upload examples use private temporary directories, restrictive fixture permissions and exclusive creation, reject existing/symlinked paths, clean up on failures/signals, preserve explicitly supplied caller-owned files, and exercise both upload modes with meaningful regression coverage. No SDK runtime, dependency, or API changes; substantive CI and CodeQL are green.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
This is an independent PR against public main. SDK CODEOWNER review requested for the example file-handling change.