fix(azure): encode deployment names consistently - #3683
Merged
Conversation
Contributor
apcha-oai
enabled auto-merge
August 19, 2026 20:33
jbeckwith-oai
approved these changes
Aug 19, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Independent two-pass security review confirms Azure deployment names remain confined to one canonical URL path segment across synchronous and asynchronous clients. Separators, encoded traversal, query/fragment delimiters, controls, and Unicode are handled safely without changing fixed-deployment routing, authentication, streaming, or realtime behavior. Focused tests and substantive CI are green; no actionable findings.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure requests that select a deployment through
modelshould handle its name consistently with other SDK path parameters. Use the existing path encoder when constructing the deployment URL, preserving the selected operation and normal deployment names.Fixed-deployment clients and non-deployment endpoints retain their existing routing behavior. Includes focused synchronous and asynchronous regression coverage.