Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): improve custom base_url example #1694

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

codefromthecrypt
Copy link
Contributor

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

OPENAI_BASE_URL defaults to https://api.openai.com/v1, so if you add a replacement and forget to append the /v1, it will result in 404s. Let's give an example that ends in v1

Additional context & links

https://github.com/openai/openai-python/blob/b2f58cba092cfb3083dc31de429fa19d89f739dc/src/openai/_client.py#L118C1-L121C52

OPENAI_BASE_URL defaults to https://api.openai.com/v1, so if you add a replacement and forget to append the /v1, it will result in 404s
@codefromthecrypt codefromthecrypt requested a review from a team as a code owner September 7, 2024 08:23
@RobertCraigie RobertCraigie changed the title README.md use realistic replacement for OPENAI_BASE_URL docs(readme): improve custom base_url example Sep 9, 2024
@RobertCraigie RobertCraigie changed the base branch from main to next September 9, 2024 10:17
@RobertCraigie RobertCraigie merged commit 05eec8a into openai:next Sep 9, 2024
2 checks passed
@RobertCraigie
Copy link
Collaborator

Thanks!

@stainless-app stainless-app bot mentioned this pull request Sep 9, 2024
stainless-app bot pushed a commit that referenced this pull request Sep 9, 2024
OPENAI_BASE_URL defaults to https://api.openai.com/v1, so if you add a replacement and forget to append the /v1, it will result in 404s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants