Skip to content

Conversation

@joseharriaga
Copy link
Collaborator

@joseharriaga joseharriaga commented Dec 9, 2025

  • Added a visitor to generate the protocol model pattern: 1) properties with setters, 2) public default constructor, 3) implicit conversion from BinaryContent for input models.
  • Applied protocol model pattern to missing types in Responses, including the derived types of StreamingResponseUpdate, ResponseDeletionResult, and ResponseItemCollectionPage.
  • Fixed an issue with CreateResponse methods overriding the value of StreamingEnabled. It is now the responsibility of the user to correctly set StreamingEnabled based on if they are calling the streaming or non-streaming method.
  • Added validation that checks the value of StreamingEnabled based on which method it is being used with and throws an exception in case of invalid combinations.
  • Changed the ConversationId property in CreateResponseOptions to match the ConversationOptions property of ResponseResult, i.e. type is now ResponseConversationOptions instead of just a string.
  • Renamed MaxToolCalls in CreateResponseOptions to MaxToolCallCount to match the property in ResponseResult.
  • Renamed Id in ResponseDeletionResult to ResponseId for clarity and consistency with other APIs in the library.
  • fixes Modify ImplicitConversionToBinaryContentVisitor to allow for exception list #863

@joseharriaga joseharriaga merged commit d496e42 into main Dec 10, 2025
2 checks passed
@joseharriaga joseharriaga deleted the joseharriaga/ResponsesProtocolModels branch December 10, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify ImplicitConversionToBinaryContentVisitor to allow for exception list

3 participants