-
Notifications
You must be signed in to change notification settings - Fork 346
Apply protocol model pattern to missing types in Responses #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
reviewed
Dec 10, 2025
christothes
reviewed
Dec 10, 2025
christothes
reviewed
Dec 10, 2025
src/Custom/Responses/Streaming/StreamingResponseContentPartAddedUpdate.cs
Show resolved
Hide resolved
christothes
reviewed
Dec 10, 2025
src/Custom/Responses/Streaming/StreamingResponseContentPartDoneUpdate.cs
Show resolved
Hide resolved
christothes
reviewed
Dec 10, 2025
christothes
reviewed
Dec 10, 2025
christothes
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryContentfor input models.StreamingResponseUpdate,ResponseDeletionResult, andResponseItemCollectionPage.CreateResponsemethods overriding the value ofStreamingEnabled. It is now the responsibility of the user to correctly setStreamingEnabledbased on if they are calling the streaming or non-streaming method.StreamingEnabledbased on which method it is being used with and throws an exception in case of invalid combinations.ConversationIdproperty inCreateResponseOptionsto match theConversationOptionsproperty ofResponseResult, i.e. type is nowResponseConversationOptionsinstead of just astring.MaxToolCallsinCreateResponseOptionstoMaxToolCallCountto match the property inResponseResult.IdinResponseDeletionResulttoResponseIdfor clarity and consistency with other APIs in the library.