Skip to content

Change GenerateSummary to Summary to match OpenAI Spec #457 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change GenerateSummary to Summary to match OpenAI Spec #457 #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a530cba
Update ResponseReasoningOptions.Serialization.cs
rafCodes Jun 19, 2025
986c483
Update ResponseReasoningOptions.cs
rafCodes Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Custom/Responses/ResponseReasoningOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ public partial class ResponseReasoningOptions
public ResponseReasoningEffortLevel? ReasoningEffortLevel { get; set; }

// CUSTOM: Renamed.
[CodeGenMember("GenerateSummary")]
[CodeGenMember("Summary")]
public ResponseReasoningSummaryVerbosity? ReasoningSummaryVerbosity { get; set; }

// CUSTOM: Make default constructor public.
public ResponseReasoningOptions()
{
}
}
}
6 changes: 3 additions & 3 deletions src/Generated/Models/ResponseReasoningOptions.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ protected virtual void JsonModelWriteCore(Utf8JsonWriter writer, ModelReaderWrit
writer.WriteNull("effort"u8);
}
}
if (Optional.IsDefined(ReasoningSummaryVerbosity) && _additionalBinaryDataProperties?.ContainsKey("generate_summary") != true)
if (Optional.IsDefined(ReasoningSummaryVerbosity) && _additionalBinaryDataProperties?.ContainsKey("summary") != true)
{
writer.WritePropertyName("generate_summary"u8);
writer.WritePropertyName("summary"u8);
writer.WriteStringValue(ReasoningSummaryVerbosity.Value.ToString());
}
if (_additionalBinaryDataProperties != null)
Expand Down Expand Up @@ -99,7 +99,7 @@ internal static ResponseReasoningOptions DeserializeResponseReasoningOptions(Jso
reasoningEffortLevel = new ResponseReasoningEffortLevel(prop.Value.GetString());
continue;
}
if (prop.NameEquals("generate_summary"u8))
if (prop.NameEquals("summary"u8))
{
if (prop.Value.ValueKind == JsonValueKind.Null)
{
Expand Down