-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chroma to Vector Database examples #262
Add Chroma to Vector Database examples #262
Conversation
Thanks for the PR; I'll take a look. Always happy to include more solutions for end users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a fun read! I feel like I actually understand how the hallucinated abstracts improve the overall performance, thanks to the notes and commentary.
This code is outside my regular scope but I happened to be here looking this notebook over anyways, so I left notes on a few minor spelling nits that I noticed while reading.
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
examples/vector_databases/chroma/hyde-with-chroma-and-openai.ipynb
Outdated
Show resolved
Hide resolved
Thanks @csvoss for catching those spelling nits! |
@ted-at-openai - let me know if there are any changes you'd like me to make here! |
I'll take a look - thanks for the ping. |
@ted-at-openai following up here again - i'm concerned that this will grow stale soon, we'd like to land this ahead of the retrieval plugin integration. |
Thanks for following up. Here is my current thinking: Right now the PR can't be merged because due to merge conflicts stemming from another update made to the notebook. Ideally I'd like to have one notebook per provider, so we don't have a huge blob of concatenated examples, which is (a) hard to read and (b) hard to have multiple people merge to. Option 1:
Option 2:
Option 1 will go fastest, but take more work from your side. I'm sorry I haven't had the time to do this; unfortunately it's not my at the top of my priority list right now. I still really appreciate your contributions, am happy to merge them as soon as ready, and am happy to continue discussing. |
Happy to resolve the conflict on our end |
92a7efa
to
7d9d3b9
Compare
All set. |
examples/vector_databases/Using_vector_databases_for_embeddings_search.ipynb
Show resolved
Hide resolved
Merged! Thanks for your patience during the long delay. Appreciate your quick changes. Glad to you have your example in the repo. |
Thanks for reviewing! I know it's a busy time, much appreciated. |
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
* Vector store notebook * HyDE with Chroma * Cleaner text * add swyx edits * Cleaned up text / outputs * Spelling nits * Fixed comment format --------- Co-authored-by: swyx <shawnthe1@gmail.com>
This PR adds Chroma to the vector database examples in the OpenAI cookbook.
Chroma is a lightweight, developer-friendly embeddings store which aims to get A.I application developers up and running with embeddings as fast as possible.
This PR:
Using_vector_databases_for_embeddings_search.ipynb
gpt3.5-turbo
api as well as theada-002
embeddings API.jsonl
format.