Skip to content

Conversation

filip-halt
Copy link
Contributor

Included the Zilliz vector database, Milvus bugfixes, and more notebooks.

Also this merge aims to clear the notebook outputs of the shared notebook. Every pull is deleting other peoples outputs and including their own. I believe the best route is to just not have outputs in the notebook instead of everyone overwriting each others work.

Filip Haltmayer added 3 commits March 20, 2023 14:52
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
@ted-at-openai
Copy link
Collaborator

Makes sense. Personally I prefer having the outputs pre-computed. That way someone can see the outputs of the example code without necessarily having to run it themselves (e.g., if they're on gibhub.com, or if they don't want to go through the trouble of setting up a vector database but do want to see what it might look like). I do recognize it makes the diffs harder to analyze.

@ted-at-openai ted-at-openai self-requested a review March 22, 2023 19:58
@ted-at-openai ted-at-openai self-assigned this Mar 22, 2023
@filip-halt
Copy link
Contributor Author

It might be worth having a standard output near the end that shows exactly what should be returned. The different sections just show how to get that input using each vector store.

@filip-halt
Copy link
Contributor Author

Is there anything that needs to be changed to get this merged? @ted-at-openai

@ted-at-openai ted-at-openai merged commit 5c94ed3 into openai:main Mar 28, 2023
@ted-at-openai
Copy link
Collaborator

Merged! Thanks for your patience. I think I'm going to split up the single notebook into one for each vector DB, to help keep things manageable. Hopefully can get that done tomorrow.

syusuke9999 pushed a commit to syusuke9999/openai-cookbook that referenced this pull request May 12, 2023
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
syusuke9999 pushed a commit to syusuke9999/openai-cookbook that referenced this pull request May 12, 2023
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
syusuke9999 pushed a commit to syusuke9999/openai-cookbook that referenced this pull request May 12, 2023
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
syusuke9999 pushed a commit to syusuke9999/openai-cookbook that referenced this pull request May 12, 2023
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
syusuke9999 pushed a commit to syusuke9999/openai-cookbook that referenced this pull request May 12, 2023
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
katia-openai pushed a commit that referenced this pull request Feb 29, 2024
* integrating zilliz and fixing milvus bugs

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* Adding Milvus and Zilliz notebooks

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

* cleaned outputs of shared notebook

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>

---------

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants