Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp Function Middleware #1372

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Gcp Function Middleware #1372

merged 5 commits into from
Aug 13, 2024

Conversation

girishd
Copy link
Contributor

@girishd girishd commented Aug 12, 2024

Summary

Added a new GPT Action - Google Cloud Function. I will be following up with a Pinecone GPT soon

Motivation

This should serve as the template to build other Google Cloud Function actions that connect to 3rd party systems - like SQL databases, etc


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • [yes ] I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • [yes ] I have conducted a self-review of my content based on the contribution guidelines:
    • [ yes] Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • [yes ] Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • [yes ] Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • [ yes] Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • [yes ] Correctness: The information I include is correct and all of my code executes successfully.
    • [yes ] Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

Copy link
Contributor

@aaronwilkowitz-openai aaronwilkowitz-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @girishd ! I added one small comment on one of the photos to edit. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please black out the callback URL? It's possibly sensitive (And even if not, it's good practice to show our customers reading our docs.)

@girishd
Copy link
Contributor Author

girishd commented Aug 13, 2024

Done!

Copy link
Contributor

@aaronwilkowitz-openai aaronwilkowitz-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@aaronwilkowitz-openai aaronwilkowitz-openai merged commit 26ba99e into main Aug 13, 2024
@aaronwilkowitz-openai aaronwilkowitz-openai deleted the gcp-function-middleware branch August 13, 2024 17:05
nelsonauner pushed a commit to nelsonauner/openai-cookbook that referenced this pull request Aug 14, 2024
Co-authored-by: Aaron Wilkowitz <157151487+aaronwilkowitz-openai@users.noreply.github.com>
joshagilend pushed a commit to joshagilend/openai-cookbook that referenced this pull request Oct 23, 2024
Co-authored-by: Aaron Wilkowitz <157151487+aaronwilkowitz-openai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants