Skip to content

fix: handle omit type in _remove_not_given() for litellm model #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
+1 −1
Merged

fix: handle omit type in _remove_not_given() for litellm model #1893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
592c3bb
fix: handle omit type in _remove_not_given for litellm model
HareeshBahuleyan Oct 14, 2025
7d7f2ff
Merge branch 'main' into litellm-toolchoice-omit-fix
HareeshBahuleyan Oct 14, 2025
eb6d382
Update check condition
HareeshBahuleyan Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agents/extensions/models/litellm_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ def _fix_tool_message_ordering(
return fixed_messages

def _remove_not_given(self, value: Any) -> Any:
if isinstance(value, NotGiven):
if value is omit or isinstance(value, NotGiven):
return None
return value

Expand Down