-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(viz): draw MCP servers #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this. Looks pretty cool! Can you resolve the CI errors?
|
@aaron-ang Ideally, instead of skipping the test, the tests should ensure that the code does not fail when rendering 3.9-compatible agents. Disabling the entire test file isn’t ideal in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this one!
Unfortunately, I can only help with PRs you've created.
If the Python version is < 3.10, we won't be able to create an agent with MCP in the first place due to version conflicts. I've added checks to only create and test for MCP server components if the version is >= 3.10. |
Thanks for quickly adjusting the tests! Sounds great to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge once all the CI jobs pass
Summary
Add nodes and edges for MCP servers in agent visualization. I'm open to suggestions to modify the style of visualizations.
Checks
make lint
andmake format
Example graph with MCP server:
