Skip to content

feat(viz): draw MCP servers #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

feat(viz): draw MCP servers #1368

merged 1 commit into from
Aug 4, 2025

Conversation

aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Aug 4, 2025

Summary

Add nodes and edges for MCP servers in agent visualization. I'm open to suggestions to modify the style of visualizations.

Checks

  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

Example graph with MCP server:
automobile_agent_graph

@aaron-ang aaron-ang changed the title feat(viz): draw mcp servers feat(viz): draw MCP servers Aug 4, 2025
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this. Looks pretty cool! Can you resolve the CI errors?

@aaron-ang
Copy link
Contributor Author

aaron-ang commented Aug 4, 2025

mcp library requires python 3.10 but our old_version_tests is pinned at version 3.9. Can we skip visualization tests for this?

@seratch
Copy link
Member

seratch commented Aug 4, 2025

@aaron-ang Ideally, instead of skipping the test, the tests should ensure that the code does not fail when rendering 3.9-compatible agents. Disabling the entire test file isn’t ideal in this case.

Copy link

@chatgpt-connector chatgpt-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this one!
Unfortunately, I can only help with PRs you've created.

@aaron-ang
Copy link
Contributor Author

aaron-ang commented Aug 4, 2025

If the Python version is < 3.10, we won't be able to create an agent with MCP in the first place due to version conflicts. I've added checks to only create and test for MCP server components if the version is >= 3.10.

@seratch
Copy link
Member

seratch commented Aug 4, 2025

Thanks for quickly adjusting the tests! Sounds great to me!

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge once all the CI jobs pass

@seratch seratch enabled auto-merge (squash) August 4, 2025 22:34
@seratch seratch merged commit 54e4087 into openai:main Aug 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants