Updating screenshot to CDN link #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenheidel
approved these changes
Mar 11, 2025
6 tasks
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
- HIGH PRIORITY openai#1: File structure refactoring (group by component type) - Target structure: statestore/, pubsub/, bindings/, secretstore/, configuration/ - Removes redundant prefixes from YAML filenames - 13 total items categorized by priority (HIGH/MEDIUM/LOW) - Includes effort estimates (35-45 hours total) and phased approach - Quick wins section for immediate value (2.5 hours) - All items tracked via manage_todo_list for traceability Rationale: Proper directory organization improves maintainability, follows coding methodology, and makes adding new components easier.
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
HIGH PRIORITY openai#1 - File Structure Refactoring Complete Directory Structure: - bindings/http.yaml (was bindings-http.yaml) - configuration/default.yaml (was configuration.yaml) - pubsub/redis.yaml (was pubsub-redis.yaml) - secretstore/env.yaml (was secretstore-env.yaml) - statestore/default.yaml (was statestore.yaml) - statestore/postgres.yaml (was statestore-postgres.yaml) - statestore/redis.yaml (was statestore-redis.yaml) Rationale: - Groups files by component type following proper coding methodology - Removes redundant prefixes from filenames - Easier to add new components of same type - Improves maintainability and discoverability Testing: - Created tests/test_dapr_component_structure.py with TDD approach - Verified Dapr sidecar loads all 6 components from subdirectories - Dapr metadata endpoint confirms all components active: * statestore (default Redis) * statestore-redis * statestore-postgres * pubsub-redis * secretstore-env * http-binding No docker-compose.yml changes needed - Dapr recursively scans subdirectories.
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
File Structure Refactoring Complete: - All subdirectories created (statestore/, pubsub/, bindings/, secretstore/, configuration/) - All 7 YAML files moved and renamed - Documentation updated (README.md files) - TDD tests created (test_dapr_component_structure.py) - Verified all 6 components load successfully via Dapr metadata endpoint Actual effort: 1.5 hours (estimated was 2-3 hours) Verification: - Dapr sidecar logs show all components loaded - Metadata endpoint confirms all 6 components active - No docker-compose.yml changes needed (Dapr scans subdirectories automatically) Remaining: Update infrastructure CLI (moved to LOW PRIORITY openai#6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CDN hosted screenshot vs. GH hosted one