Skip to content

the same isinstance(output, ResponseFunctionToolCall) check twice in "_run_impl.py " #658

Open
@beston123

Description

@beston123

The code performs the same isinstance(output, ResponseFunctionToolCall) check twice. This is redundant and may confuse future maintainers or introduce unnecessary complexity.

elif not isinstance(output, ResponseFunctionToolCall):

           elif not isinstance(output, ResponseFunctionToolCall):
                logger.warning(f"Unexpected output type, ignoring: {type(output)}")
                continue

            # At this point we know it's a function tool call
            if not isinstance(output, ResponseFunctionToolCall):
                continue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions