-
Notifications
You must be signed in to change notification settings - Fork 463
fix: #639 Type issue with realtime agent handoffs #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@openai/agents-realtime': patch | ||
| --- | ||
|
|
||
| fix: #639 Type issue with realtime agent handoffs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
packages/agents-realtime/test/realtimeAgentHandoffs.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { z } from 'zod'; | ||
| import { | ||
| RealtimeAgent, | ||
| tool, | ||
| RealtimeContextData, | ||
| type RealtimeAgentConfiguration, | ||
| } from '../src'; | ||
|
|
||
| describe('RealtimeAgent handoffs', () => { | ||
| it('accepts handoffs sharing the session context', () => { | ||
| type SessionContext = { userId: string }; | ||
|
|
||
| const specialist = new RealtimeAgent<SessionContext>({ | ||
| name: 'specialist', | ||
| }); | ||
|
|
||
| const mainAgent = new RealtimeAgent<SessionContext>({ | ||
| name: 'main', | ||
| handoffs: [specialist], | ||
| }); | ||
|
|
||
| expect(mainAgent.handoffs).toEqual([specialist]); | ||
| }); | ||
|
|
||
| it('accepts handoffs with default context parameters', () => { | ||
| const specialist = new RealtimeAgent({ | ||
| name: 'specialist', | ||
| }); | ||
|
|
||
| const mainAgent = new RealtimeAgent({ | ||
| name: 'main', | ||
| handoffs: [specialist], | ||
| }); | ||
|
|
||
| expect(mainAgent.handoffs).toEqual([specialist]); | ||
| }); | ||
|
|
||
| it('supports tool definitions without RealtimeContextData', () => { | ||
| type SessionContext = { userId: string }; | ||
| const parameters = z.object({ message: z.string() }); | ||
| const echoTool = tool<typeof parameters, SessionContext>({ | ||
| name: 'echo', | ||
| description: 'Echo the user id with the provided message.', | ||
| parameters, | ||
| execute: async ({ message }, runContext) => { | ||
| // if you want to access history data, the type parameter must be RealtimeContextData<SessionContext> | ||
| // console.log(runContext?.context?.history); | ||
| return `${runContext?.context?.userId}: ${message}`; | ||
| }, | ||
| }); | ||
|
|
||
| const agent = new RealtimeAgent<SessionContext>({ | ||
| name: 'Tool Agent', | ||
| tools: [echoTool], | ||
| }); | ||
| expect(agent.tools).toContain(echoTool); | ||
| }); | ||
|
|
||
| it('supports tool definitions that rely on RealtimeContextData', () => { | ||
| type SessionContext = { userId: string }; | ||
| const parameters = z.object({ message: z.string() }); | ||
| const echoTool = tool< | ||
| typeof parameters, | ||
| RealtimeContextData<SessionContext> | ||
| >({ | ||
| name: 'echo', | ||
| description: 'Echo the user id with the provided message.', | ||
| parameters, | ||
| execute: async ({ message }, runContext) => { | ||
| // if you want to access history data, the type parameter must be RealtimeContextData<SessionContext> | ||
| console.log(runContext?.context?.history); | ||
| return `${runContext?.context?.userId}: ${message}`; | ||
| }, | ||
| }); | ||
|
|
||
| const agent = new RealtimeAgent<SessionContext>({ | ||
| name: 'Tool Agent', | ||
| tools: [echoTool], | ||
| }); | ||
| expect(agent.tools).toContain(echoTool); | ||
| }); | ||
|
|
||
| it('rejects handoffs with incompatible session contexts', () => { | ||
| type SessionContext = { userId: string }; | ||
| type OtherContext = { language: string }; | ||
|
|
||
| const specialist = new RealtimeAgent<SessionContext>({ | ||
| name: 'specialist', | ||
| }); | ||
|
|
||
| const validConfig: RealtimeAgentConfiguration<SessionContext> = { | ||
| name: 'main', | ||
| handoffs: [specialist], | ||
| }; | ||
|
|
||
| expect(validConfig.handoffs).toEqual([specialist]); | ||
|
|
||
| const invalidConfig: RealtimeAgentConfiguration<OtherContext> = { | ||
| name: 'incompatible', | ||
| // @ts-expect-error - mismatched handoff context should not be allowed | ||
| handoffs: [specialist], | ||
| }; | ||
|
|
||
| expect(invalidConfig).toBeDefined(); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrapping with RealtimeContextData just appends
historyproperty as optional, so this is safe for both tsc and runtime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was great, Thank you for resolving so fast.