Ask user question UI footer improvements #9949

charley-oai · 2026-01-27T00:22:19Z

Summary

Polishes the request_user_input TUI overlay

Question 1 (unanswered)

Tab to add notes

Question 2 (unanswered)

Ctrl+p or h to go back to q1 (answered)

Unanswered freeform

Key changes

Footer tips wrap at tip boundaries (no truncation mid‑tip); footer height scales to wrapped tips.
Keep tooltip text as Esc: interrupt in all states.
Make the full Tab: add notes tip cyan/bold when applicable; hide notes UI by default.
Notes toggling/backspace:
- Tab opens notes when an option is selected; Tab again clears notes and hides the notes UI.
- Backspace in options clears the current selection.
- Backspace in empty notes closes notes and returns to options.
Selection/answering behavior:
- Option questions highlight a default option but are not answered until Enter.
- Enter no longer auto‑selects when there’s no selection (prevents accidental answers).
- Notes submission can commit the selected option when present.
- Freeform questions require Enter with non‑empty text to mark answered; drafts are not submitted unless committed.
Unanswered cues:
- Skipped option questions count as unanswered.
- Unanswered question titles are highlighted for visibility.
Typing/navigation in options:
- Typing no longer opens notes; notes are Tab‑only.
- j/k move option selection; h/l switch questions (Ctrl+n/Ctrl+p still work).

Tests

Added unit coverage for:
- tip‑level wrapping
- focus reset when switching questions with existing drafts
- backspace clearing selection
- backspace closing empty notes
- typing in options does not open notes
- freeform draft submission gating
- h/l question navigation in options
Updated snapshots, including narrow footer wrap.

Why

These changes make the ask‑user‑question overlay:

safer (no silent auto‑selection or accidental freeform submission),
clearer (tips wrap cleanly and unanswered states stand out),
more ergonomic (Tab explicitly controls notes; backspace acts like undo/close).

Codex author

codex fork 019bfc3c-2c42-7982-9119-fee8b9315c2f

charley-oai · 2026-01-27T00:28:35Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c05ed321ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/selection_popup_common.rs

charley-oai · 2026-01-27T01:15:51Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

Lines 493 to 495 in 0de7256

    
           KeyCode::Enter => { 
        
               self.select_current_option(); 
        
               self.go_next_or_submit();

Allow submitting without auto-selecting option

With the new default of “no selection,” pressing Enter in the options list always calls select_current_option, which clamps a None selection to index 0. That means a user who leaves an options question unanswered (especially on the last question where Enter submits) will unintentionally submit the first option instead of an empty answer, despite the UI showing “No option selected.” Consider skipping select_current_option when Enter is used to submit and no option is currently selected.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-27T01:36:54Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f86aacdd0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/render.rs

charley-oai · 2026-01-27T06:57:43Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

Lines 557 to 559 in d554efa

    
           KeyCode::Enter => { 
        
               self.select_current_option(); 
        
               self.go_next_or_submit();

Avoid auto-selecting on Enter when no option chosen

With the new “no selection by default” behavior, hitting Enter in the options focus path still calls select_current_option(), which clamps to index 0 and submits. In a single-question options prompt (no Ctrl+N path), a user cannot submit an unanswered response despite the UI showing “No option selected” and the new empty-answer behavior. This reintroduces the accidental-selection problem and makes skipping impossible in that scenario. Consider only submitting the current selection on Enter (if one exists) or requiring an explicit selection action first.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-27T07:06:03Z

@codex review this

chatgpt-codex-connector · 2026-01-27T07:16:11Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-27T17:03:12Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0179dfb4a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T17:30:12Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef13a30c85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T20:22:34Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2fd6a61c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T21:37:59Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bd6abaf72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:00:15Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d8fd29b18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:22:14Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5c4303885

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:37:02Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 401917a16f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai · 2026-01-27T22:46:15Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c8cd47a51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs

charley-oai force-pushed the ask-user-question-ui-footer-improvements branch from 2a24f03 to c05ed32 Compare January 27, 2026 00:28

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/selection_popup_common.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

charley-oai force-pushed the ask-user-question-ui-footer-improvements branch from 0de7256 to f86aacd Compare January 27, 2026 01:36

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/render.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the ask-user-question-ui-footer-improvements branch from c238b19 to d554efa Compare January 27, 2026 06:57

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai force-pushed the ask-user-question-ui-footer-improvements branch from 0179dfb to ef13a30 Compare January 27, 2026 17:27

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

aibrahim-oai and others added 12 commits January 27, 2026 11:26

Add composer config and shared menu surface helpers

b59d8a5

Reuse ChatComposer in request_user_input overlay

c01171c

Resolve duplicate menu surface helpers after cherry-pick

20740f2

Add composer config and shared menu surface helpers

5aa2ac6

Improve ask user question tool UI footer

8b8661d

Lint

83605dc

Simplify notes cursor gating boolean

bda4132

Snapshot test tweaks

9af659a

Constrain Ctrl+P formatting to just questions UI

8642bdd

Unanswered warning

8b894c5

Last question enter guard

86f79b0

Fix test

31d8ab4

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai added 3 commits January 27, 2026 12:36

Avoid auto-selecting options on Enter without selection

f0600f9

Toggle notes with Tab in request_user_input

9561b4c

Refine ask-user-question navigation and answered state

7baf2c1

aibrahim-oai approved these changes Jan 27, 2026

View reviewed changes

Lint, dd unnecessary test

9bd6aba

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

charley-oai added 2 commits January 27, 2026 13:50

Polish ask-user-question UX details

40b694f

Only submit committed freeform answers

1d8fd29

Lint

07d939e

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

Restore typing for options focus

e5c4303

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Outdated Show resolved Hide resolved

charley-oai added 2 commits January 27, 2026 14:29

Naming nits

f8479c3

Require tab to open notes

401917a

charley-oai marked this pull request as ready for review January 27, 2026 22:41

Restore h/l question navigation

8c8cd47

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai enabled auto-merge (squash) January 27, 2026 22:47

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/request_user_input/mod.rs Show resolved Hide resolved

charley-oai disabled auto-merge January 27, 2026 22:57

charley-oai merged commit 19d8f71 into main Jan 27, 2026
51 of 58 checks passed

charley-oai deleted the ask-user-question-ui-footer-improvements branch January 27, 2026 22:57

github-actions bot locked and limited conversation to collaborators Jan 27, 2026

	KeyCode::Enter => {
	self.select_current_option();
	self.go_next_or_submit();

Ask user question UI footer improvements #9949

Ask user question UI footer improvements #9949

Uh oh!

Conversation

charley-oai commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key changes

Tests

Why

Codex author

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 27, 2026

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Jan 27, 2026

Uh oh!

charley-oai commented Jan 27, 2026 •

edited

Loading