file-search: improve file query perf #9939
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b32e0cade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50044e0df1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6baa80878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c262d5ade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74edc97142
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/file-search/src/lib.rs
Outdated
| let top_changed = matches != last_matches; | ||
| if top_changed { | ||
| last_matches = matches; | ||
| } | ||
|
|
There was a problem hiding this comment.
The update emission is gated solely on top_changed, which only compares the matches list. If the user changes the query after the walk has completed and the resulting top-N stays identical (e.g., switching between two queries that both return no matches, or queries that hit the same top results), no on_update will fire and on_complete will not fire again (it only runs once per walk). In the TUI flow this leaves the popup stuck in the “waiting” state for the new query with no further updates, even though the search is finished. Consider treating a query change (or total_match_count change) as an update trigger, or including the query in the change detection.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e289670f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| session.update_query(pattern_text); | ||
| let snapshot = session.join()?; | ||
| Ok(FileSearchResults { | ||
| matches: snapshot.matches, | ||
| total_match_count: snapshot.total_match_count, |
There was a problem hiding this comment.
The new run path always returns the latest snapshot, even if cancel_flag was set while the walk/matcher was in progress. In the app-server flow, fuzzy_file_search uses the cancellation token to abort older requests (see codex_message_processor::fuzzy_file_search), so returning partial matches for a canceled run will send stale results for a superseded query. Previously run explicitly returned empty results when cancel_flag was true; consider restoring that behavior (or have session.join() indicate cancellation) so canceled searches do not emit results.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
cc @shijie-oai for VSCE behavior but I think we might need to address this? Off the top of my head I believe this should make for a reasonable UX, and I know we tested this
There was a problem hiding this comment.
if the client cancels the request then i don't think we care what the response is, right?
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 405e02a44c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da6bbff015
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
switch nucleo-matcher for nucleo and use a "file search session" w/ live updating query instead of a single hermetic run per query.