-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[connectors] Support connectors part 2 - slash command and tui #9728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/connectors_codex_cli_1
…/connectors_codex_cli_1
…/connectors_codex_cli_4
| @@ -3,7 +3,7 @@ | |||
| //! It is responsible for: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes in this file is about generalizing skills to mentions.
…/connectors_codex_cli_4
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94720ef2c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/tui/src/chatwidget.rs
Outdated
| if matches!(self.connectors_cache, ConnectorsCacheState::Uninitialized) { | ||
| self.prefetch_connectors(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retry connector fetch after failures
The /apps flow only calls prefetch_connectors() when the cache is Uninitialized, so if the initial prefetch fails (e.g., user isn’t logged in yet, transient network error, MCP not ready), the cache stays Failed and subsequent /apps invocations only replay the error without reattempting the fetch. That effectively requires a new session to recover, even after the underlying issue is resolved. Consider retrying when the cache is Failed (or clearing the cache on demand) so /apps can recover in-session.
Useful? React with 👍 / 👎.
…/connectors_codex_cli_4
…/connectors_codex_cli_4
…/connectors_codex_cli_4
…/connectors_codex_cli_4
/appsslash command to browse the apps in tui.$.