Skip to content

Conversation

@mzeng-openai
Copy link
Contributor

@mzeng-openai mzeng-openai commented Jan 23, 2026

  • Support /apps slash command to browse the apps in tui.
  • Support inserting apps to prompt using $.
  • Lots of simplification/renaming from connectors to apps.

@@ -3,7 +3,7 @@
//! It is responsible for:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes in this file is about generalizing skills to mentions.

@mzeng-openai mzeng-openai marked this pull request as ready for review January 23, 2026 06:26
@mzeng-openai mzeng-openai requested review from aibrahim-oai and jif-oai and removed request for joshka-oai January 27, 2026 00:10
@jif-oai
Copy link
Collaborator

jif-oai commented Jan 27, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94720ef2c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 5059 to 5061
if matches!(self.connectors_cache, ConnectorsCacheState::Uninitialized) {
self.prefetch_connectors();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retry connector fetch after failures

The /apps flow only calls prefetch_connectors() when the cache is Uninitialized, so if the initial prefetch fails (e.g., user isn’t logged in yet, transient network error, MCP not ready), the cache stays Failed and subsequent /apps invocations only replay the error without reattempting the fetch. That effectively requires a new session to recover, even after the underlying issue is resolved. Consider retrying when the cache is Failed (or clearing the cache on demand) so /apps can recover in-session.

Useful? React with 👍 / 👎.

@mzeng-openai mzeng-openai merged commit b9cd089 into main Jan 29, 2026
32 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/connectors_codex_cli_4 branch January 29, 2026 03:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants