feat: tui beta for collab #9690
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 472c177dc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fab3f30c30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let Event { msg, .. } = event; | ||
| if matches!(msg, EventMsg::ShutdownComplete) { |
There was a problem hiding this comment.
When switching to an agent thread, replayed events flow through handle_codex_event_replay, but this method drops the original event.id. Approval requests depend on that ID: dispatch_event_msg passes id.unwrap_or_default() into on_exec_approval_request / on_apply_patch_approval_request, and the resulting ApprovalRequest is keyed by that ID. If an approval was requested while the thread was inactive, replaying it with an empty ID makes the approval response impossible to match in core, leaving the agent thread permanently blocked. This can be reproduced by letting a background agent hit an approval, then switching to it via /agent.
Useful? React with 👍 / 👎.
Screen.Recording.2026-01-22.at.16.33.43.mov