Show OAuth error descriptions in callback responses #9654
Merged
+53
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
error_description, making it hard to debug OAuth failures.Description
codex-rs/rmcp-client/src/perform_oauth_login.rsto surfaceerror_descriptionvalues from the callback query in the HTTP response.CallbackOutcomeenum and changeparse_oauth_callbackto return it, parsingcode,state, anderror_descriptionfrom the query string.spawn_callback_serverto match onCallbackOutcomeand returnOAuth error: <description>with a 400 status whenerror_descriptionis present, while preserving the existing success and invalid flows.Testing
just fmtin thecodex-rsworkspace to format changes successfully.cargo test -p codex-rmcp-clientand all tests passed.Codex Task