fix(exec): skip git repo check when --yolo flag is used #9590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7522
The
--yolo(--dangerously-bypass-approvals-and-sandbox) flag is documented to skip all confirmation prompts and execute commands without sandboxing, intended solely for running in environments that are externally sandboxed. However, it was not bypassing the trusted directory (git repo) check, requiring users to also specify--skip-git-repo-check.This change makes
--yoloalso skip the git repo check, matching the documented behavior and user expectations.Changes
codex-rs/exec/src/lib.rsto check fordangerously_bypass_approvals_and_sandboxflag in addition toskip_git_repo_checkwhen determining whether to skip the git repo checkTesting
cargo check -p codex-execcargo test -p codex-exec(34 passed, 8 integration tests failed due to unrelated API connectivity issues)🤖 Generated with Claude Code