Skip to content

Conversation

@joshka-oai
Copy link
Collaborator

  • set the pill text to white so it stays legible on light themes
  • render the icon in bold light cyan so it stands out
  • reran just fmt, just fix -p codex-tui2, and cargo test -p codex-tui2 after the tweak
Screen.Recording.2026-01-02.at.9.03.02.PM.mov

- set the pill text to white so it stays legible on light themes
- render the icon in bold light cyan so it stands out
- reran `just fmt`, `just fix -p codex-tui2`, and
  `cargo test -p codex-tui2` after the tweak
@joshka-oai joshka-oai requested a review from tibo-openai January 3, 2026 05:11
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40152db5b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

let pill_area = Rect::new(x, y, pill_width, 1);
let base_style = Style::new().bg(Color::DarkGray);
let icon_style = base_style.fg(Color::Cyan);
let base_style = Style::new().bg(Color::DarkGray).fg(Color::White);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid hardcoded white foreground in pill style

For terminals with custom ANSI palettes (common in light themes), forcing Color::White can yield poor contrast or outright illegible text against the configured DarkGray background, whereas using the theme’s default foreground preserves user-tuned readability. The TUI styling guidance in the repo explicitly warns against hardcoded white for this reason, so this change risks a regression for users who remap ANSI colors.

Useful? React with 👍 / 👎.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional for now - we can come back to tweak exact colors on this one (or make it so that this works similarly to the user prompt areas to darken / lighten the foreground colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants