Skip to content

Conversation

@gpeal
Copy link
Collaborator

@gpeal gpeal commented Jan 3, 2026

The Responses API requires that all tool names conform to '^[a-zA-Z0-9_-]+$'. This PR replaces all non-conforming characters with _ to ensure that they can be used.

Fixes #8174

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if used_names.contains(&qualified_name) {
warn!("skipping duplicated tool {}", qualified_name);
continue;

P2 Badge Disambiguation missing for sanitized name collisions

When two MCP tools differ only by characters that get sanitized (e.g., server.one vs server_one), both map to the same qualified_name. The new sanitization introduces this collision, but the code now just skips the second entry when used_names already contains the sanitized key, which silently drops a valid tool from the aggregated map. This is a regression because previously both tools were distinct; now one becomes unreachable. Consider appending a hash of the raw name on collision (as the comment suggests) instead of skipping.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP tool naming scheme

2 participants